Mutability and indices for Gauss sparse matrices #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the assignment to work, sparse matrices have to be mutable (which they always were: one could call SetEntry on them without problems). There is scope to make immutable variants of these matrices in the future.
|
Your first commit breaks the package PrimaryDecomposition. I need to investigate. |
|
@markuspf: Let us please talk about this PR this week. |
mohamed-barakat
force-pushed
the
master
branch
from
e38a0d4 to
03dcbc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things (which I could split into 2 PRs if requested):
IsMutablefilter to sparse matrices. They were always mutable, becauseSetEntryworked on them.MakeImmutablenow works, but we're missingMutableCopyMat.sparsemat[i,j]andsparsemat[i,j] := 4access for sparse matrices.